FileSieve 4

no task description

no task description

no task description

Closing the Method/Modifer selection window with the titlebar close button results in a Disposed error when opening the window again.

There’s something very wrong with the whole Profile and Method/Modifier interaction in regards to the currently active settings.

Profile.Active.ActiveMethod.MethodSettings contains the correct settings
Profile.Active.ActiveMethod.Method.Settings contains the INCORRECT settings

When FileSieve (FS) encounters a file that already exists in the destination and the user has set some overwrite rules, FS generates a filename based on the entered Rename Mask and tests to see if that exists. If it does, it then generates another name (based on the # code (%file_number% in 4.36); that hash symbol represents a number that is incremented each time an on-disk collision is detected) and tests that.

Due to a bug in 4.35 and earlier (unknown at which point the bug was introduced but it may have been due to some major changes to the engine code - specifically the Prescanning step - so FS can gather additional metadata on files to give plugins more control and flexibility), the first attempt at generating a filename was always successful regardless of if that file existed on-disk.

The reason for this is that it was using the wrong path to check for the file’s existence.

Fixed in 4.36.

no task description

no task description

See forum post.

This...

\%GENRE_FIRST%\%ALBUM_ARTIST_FIRST%\%ALBUM_TITLE%\

becomes this...

Y:\Music\ContemporaryTedCrillyA Song for Europe\FileName.mp3

Initial thoughts are that FileSieve is stripping slashes due to - possibly - a call to MakeFilesystemLegal().

Selecting the EXIF plugin within the Methods window causes the following exception:

• Error: The method or operation is not implemented
• At: Method.Exif.Plugin.get_Capabilities()

For the end user, this exception can be safely ignored while a fix is being prepared.

This bug was submitted via the Pique exception service; big thanks to the user that reported this!

While the Find Replace method is selected within the Methods window, clicking on Verify Settings causes the following exception:

• Error: Object reference not set to an instance of an object
• At: FS.Main.Forms.Methods.Verify(Boolean onlyShowErrors)

—-
This bug was submitted via the Pique exception service; big thanks to the user that reported this!

Using the Profile Manager, clicking on New but keeping the default New Profile name and hitting enter doesn’t rename the Guid-based on-disk file to “New Profile” and instead keeps the generated Guid.

Discovered while implementing the new Trigger system.

Exception: Value of ‘720’ is not valid for ‘Value’. ‘Value’ should be between ‘minimum’ and ‘maximum’. Parameter name: Value

at System.Windows.Forms.ProgressBar.set_Value(Int32 value)
at FS.Main.Core.Results.ResultsControls.UpdateProgressBar()

When there are multiple profiles defined, it appears the Method settings for one (maybe the first) profile is loaded despite another profile having been auto-selected at during startup.

Removing the extra profile results in the Method settings being correctly loaded for the profile.

Further testing is required to see if Modifiers - and anything else - are affected.

EDIT: Can’t seem to delete this task, so instead see the replacement task  FS#281 .

Message: Object reference not set to an instance of an object.

Runtime: 2485 seconds

at FS.Main.Core.Process.set_IsPaused(Boolean value)
at FS.Main.Core.Process.Stop()
at FS.Main.Forms.Main.cmdProcessing_Stop_Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message m)
at System.Windows.Forms.ButtonBase.WndProc(Message m)
at System.Windows.Forms.Button.WndProc(Message m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Submitted via the Pique exception service; thanks to the submitter!

The default value of the MaximumFilesize property was incorrectly set to 0 which resulted in the property’s value being set back to 0 if it was ever changed to -1 (minus one meaning that no max size check should be performed).

With the Classification method and the Move copy mode selected, FileSieve errors while trying to move files to the destination. This shouldn’t(!) be specific to just the Classification method as it itself doesn’t actually do any I/O of its own, so any method could expose this problem.

The Process.ProcessItem() log entry also doesn’t actually say what the reason for the failure was. Presumably this is because the reason isn’t easily accessible downstream. Either way, get that fixed as well.

Thanks to M. Buckton for reporting

For example, the following path:

\\server\path\

The first slash of the two leading slashes is being treated as a switch character and consequently is being stripped from the UNC, so textForge cannot open it correctly.

There is now a check within the BiQubic.Suite.Core.AppFramework library that now determines if a command-line parameter starts with a double-slash; if it does, then it is treated as an unswitched parameter.

no task description

no task description

When the active plugin has opened a window (eg. the EXIF/Tag plugins have their own EXIF/Tag viewers) and the active plugin is changed to another plugin, the window belonging to the former plugin stays open. This results in a dangling reference and eventually an exception when the user/application closes that window.

Plugins that open any child windows will need to close those windows when the plugin becomes inactive.

Child windows are already closed on SettingsEditor.Closing(), but ideally an event should be added to SettingsEditor so plugins know when they’ve been deselected so they can take appropriate action - such as closing aforementioned child windows.

no task description

Double-clicking a tag field within the Tag Method’s Tag Viewer results in a crash.

Any plugins that pass a path back to FileSieve that start with either a \ or / slash character results in the location of the respective item not being placed onto the destination path.

– original description –

The Tag method doesn’t prepend the Profile’s Destination location to the path of processed items, and neither do any other

This bug was submitted via forum; big thanks to odwofford for reporting this!

When processing, do something with files that have illegal characters in their filename.

Despite Windows not allowing such chars, they can still be created via some programs. FileSieve should have a setting (plugin?) that can dictate what should happen to them - probably replace them with valid alternatives.

Known places that throw (caught) exceptions:

• FileSieve4.Plugin\Item.UpdatePaths() : line 262
• FileSieve4.Main\Core\Process.ProcessItem() : line 751 (CreateDirectory)

This issue is related to (part of?) existing issue 269.

The following combinations lead to unexpected results in the location of the created directories. I am using modifiers to replace characters that are invalid for Windows directory names. They are working as expected except for the quirks identified below.

Step 2 - Destination: Set to F:\
Step 3 - Options - Method - Metadata - Tag:

 Name Mask:  \Music\PlaylistReorg\%GENRES%\%ALBUM_ARTIST_FIRST%\%ALBUM_TITLE%\
 Checked: Replace any slash characters encountered within the Genres tag.

Step 3 - Options - Modifiers:

 [All modifier rules created to handle characters in ALBUM_ARTIST_FIRST and ALBUM_TITLE that are invalid for Windows directory names]
 Find : Replace With -
 Find ? Replace With NULL
 Find # Replace With NULL
 Find & Replace With and
 Find , Replace With NULL
 Find + Replace With and
 Find * Replace With -

Renaming Results:

 New file name is set to \Music\PlaylistReorg\... and saved to the root of the C: drive

If the name mask is changed to F:\Music\PlaylistReorg\%GENRES%\%ALBUM_ARTIST_FIRST%\%ALBUM_TITLE%\

 [Explicitly using the Drive letter]

Renaming Results:

 New file name is set to F:\F-\Music\PlaylistReorg\... and saved to the correct drive (F:) but underneath a new directory F-

Finally, if the name mask is changed to Music\PlaylistReorg\%GENRES%\%ALBUM_ARTIST_FIRST%\%ALBUM_TITLE%\ [removing the leading \]

Renaming Results:

 New file name is set to F:\F-\Music\PlaylistReorg\... and saved to the correct drive (F:) but underneath a new directory F-

The modifier rules work correctly on the %ALBUM_ARTIST_FIRST% and %ALBUM_TITLE% variables to create the correct sub-directories under F-. The check box option correctly corrects the / character in the %GENRES% value to the - character as well.

The issue appears to be restricted to how the drive letter is being handled. The outcome of all of the combinations above results in the correct reorganization of the files from a single flat directory into multiple correct sub-directories. The new sub-directories end up, however, either in the root directory of the default C: drive or in a new directory F- on the F: drive.

Reported by Douglas Wofford in Task#273:

“The second issue is the result of a quirk with how Windows itself corrects an invalid character. There are few album names in my files that end with a period [.], for example R.E.V.O. or Shakira. Windows allows you to type in (or submit) a path like this ‘F:\Music\PlaylistReorg\RockPop\Walk Off The Earth\R.E.V.O. \’ with no error. The path that gets created, however, ‘F:\Music\PlaylistReorg\RockPop\Walk Off The Earth\R.E.V.O\’ – Windows strips off the final . and space. As result, when FileSieve attempts to move or copy the file into the directory Windows confirmed was created, the directory doesn’t exist and the move/copy fails. This is a tough one since it’s kind of weird one-off problem.”

no task description

While FileSieve is being launched, the loaded Profile is immediately saved back out again.

Eliminate this unnecessary save I/O and investigate any other such cases.

When adding/removing/clearing nodes within the tvwFolders TreeView, the Parent property isn’t being correctly set which results in an error when using drag & drop to move those Folders around.

For now, FileSieve 4.15 just displays a friendly error message and notes that the bug will be fixed within the next version.

Reported by Douglas Wofford in Task#273:

“The issue is with the option to have a slash character in Genres replaced with a -. This is not new to the new build – it was happening before – but I had missed it. I’ve included a log file showing what happens. Basically, the routine is inserted the - character some of the time, but most of time it’s just eliminating the character. So, you will see some path names as F:\Music\Rock-Pop\... but most path names as F:\Music\RockPop\... or Blues-Folk and BluesFolk. Unfortunately, I don’t see any kind of pattern related to how the Genre name is handled.”

Running FileSieve with the -portable parameter causes it to crash; this is likely down to the new automation support, especially as there’s a delay for a second or two before the crash happens as that’s when Automation is invoked.

Thanks to K. Armstrong for reporting

After a MetroForm has been opened, all ToolStrip renderers are being drawn with the system’s accent colour.

While this makes absolutely no difference to the end user, it would still be good to get this fixed as there shouldn’t really be any reason it would fire multiple times (10, while working on the Find Replace plugin).

no task description

The drop-shadow under banner in the main window has an incorrect EndColor set. It appears to be set to SystemColors.Control as opposed to the custom RGB(230, 230, 230) of the main window’s BackColor.

Consequently, there appears to be a bright “halo” line across the bottom of the shadow.

Due to moving over to the new, enhanced tooltips in 4.29, the banner in the main window isn’t having its default “This does something or whatever.” text updated to reflect the selected tab in the menu.

no task description

XML is being dropped, so remove all traces of XML.

Now that the tracker at Bugs.BootBlock.co.uk is live and has replaced FileSieve @ Trello, all references to Trello should be replaced with the new tracker.

Although, saying that, I’m not sure the sub-domain should necessarily be called Bugs as it’s more than that. Maybe rename it to Tracker.

no task description

The new Source Item Editor in 4.07 may look daunting at first to newcomers, so add a Show Advanced (drop-down arrow) like in previous versions to show all of the additional settings and options.