0000523: SourceItemRootDriveCheck incorrectly used with Destination-in-source logic

ID	Project	Category	View Status	Date Submitted	Last Update

0000523	FileSieve	Backend / Core	public	2020-04-07 10:47	2020-04-07 10:56

Reporter	BootBlock	Assigned To	BootBlock
Priority	high	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	4.53
Target Version	4.54	Fixed in Version	4.54

Summary	0000523: SourceItemRootDriveCheck incorrectly used with Destination-in-source logic
Description	By default, FileSieve checks to ensure that the `Destination` isn't present as a Source Item before processing begins (potential for a bit of weirdness to happen); when this is true, FileSieve is incorrectly telling the user that they should set `SourceItemRootDriveCheck` to false to disable the message... which is wrong. Instead, add a new item that is more suited to this setting; probably to the `Items` section of the Settings window as it's looking a bit bare. While I'm poking around here, this new setting should be set to `false` by default as it may not be that much of a big deal these days (file scanning modes pre-scan files beforehand; `yield` and the like could be an issue?) and it appears to be causing more confusion than it solves.
Tags	Settings

Date Modified	Username	Field	Change
2020-04-07 10:47	BootBlock	New Issue
2020-04-07 10:47	BootBlock	Assigned To	=> BootBlock
2020-04-07 10:47	BootBlock	Tag Attached: Settings
2020-04-07 10:55	BootBlock	Note Added: 0000250
2020-04-07 10:56	BootBlock	Status	new => closed
2020-04-07 10:56	BootBlock	Resolution	open => fixed
2020-04-07 10:56	BootBlock	Fixed in Version	=> 4.54

BootBlock 2020-04-07 10:55 administrator ~0000250	There's now a `Allow Destination as Source Item` option in Settings - Items, which is on by default.